Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3917): Throw an error when directConnection is set with multiple hosts #3143

Merged
merged 3 commits into from Feb 14, 2022
Merged

fix(NODE-3917): Throw an error when directConnection is set with multiple hosts #3143

merged 3 commits into from Feb 14, 2022

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

This PR updates the URI parsing logic to throw an error when the directConnection option is set with more than one host.

Is there new documentation needed for these changes?

No, I don't think so.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-3917-parsing-direct-connection-multiple-hosts-errors branch from f721ad6 to 15127fe Compare February 11, 2022 16:44
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 11, 2022
@baileympearson baileympearson force-pushed the NODE-3917-parsing-direct-connection-multiple-hosts-errors branch from 4402e18 to 6c28494 Compare February 14, 2022 14:48
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 14, 2022
@dariakp dariakp merged commit b192493 into main Feb 14, 2022
@dariakp dariakp deleted the NODE-3917-parsing-direct-connection-multiple-hosts-errors branch February 14, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@baileympearson @addaleax @nbbeeken @dariakp