Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3866): Add let option to ReplaceOptions for replaceOne operation #3148

Merged
merged 3 commits into from Feb 18, 2022
Merged

feat(NODE-3866): Add let option to ReplaceOptions for replaceOne operation #3148

merged 3 commits into from Feb 18, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 17, 2022 •
edited by dariakp

Description

What is changing?

This PR adds support for the let option in ReplaceOptions.

Is there new documentation needed for these changes?

Yes.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title feat(DRIVERS-2027): Add let option to ReplaceOptions feat(NODE-3866): Add let option to ReplaceOptions Feb 17, 2022
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 18, 2022
@dariakp dariakp self-assigned this Feb 18, 2022
dariakp
dariakp requested changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json file has a spacing issue like on the other PR (4 instead of 2), otherwise LGTM

@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 18, 2022
@dariakp dariakp changed the title feat(NODE-3866): Add let option to ReplaceOptions feat(NODE-3866): Add let option to ReplaceOptions for replaceOne operation Feb 18, 2022
@durran
Copy link
Member

durran commented Feb 18, 2022

Same comment as @dariakp. Can just copy it from the specs repo - it's formatted properly there.

@dariakp dariakp merged commit f76635a into main Feb 18, 2022
@dariakp dariakp deleted the DRIVERS-2027-add-let-to-replace-options branch February 18, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@baileympearson @durran @dariakp