Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4014): Add let option to bulk write operations #3160

Merged
merged 8 commits into from Mar 11, 2022
Merged

feat(NODE-4014): Add let option to bulk write operations #3160

merged 8 commits into from Mar 11, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Mar 4, 2022 •
edited

Description

What is changing?

This PR adds support for the let option for bulk operations. This PR also includes a fix to the crud spec tests from this PR: mongodb/specifications#1154.

The failing tests are unrelated to the changes in this PR and are failing on main.

  • adl tests failing are a known issue across drivers
  • socks5 & custom csfle tests are failing against master in libmongocrypt - this is a known issue and is being investigated
Is there new documentation needed for these changes?

Yes.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson
Copy link
Contributor Author

evergreen rebuild

@baileympearson
Copy link
Contributor Author

evergreen retry

@baileympearson baileympearson changed the title Add let option to bulk write feat(NODE-4014): Add let option to bulk write operations Mar 7, 2022
@baileympearson baileympearson marked this pull request as ready for review March 7, 2022 19:55
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 8, 2022
@dariakp dariakp self-assigned this Mar 8, 2022
dariakp
dariakp requested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, otherwise LGTM

test/tools/unified-spec-runner/operations.ts Outdated Show resolved Hide resolved
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 10, 2022
@baileympearson baileympearson force-pushed the NODE-4014-add-let-to-bulk-write branch from 7eb64a0 to 244f7a8 Compare March 10, 2022 21:54
@dariakp dariakp merged commit 6f633d1 into main Mar 11, 2022
@dariakp dariakp deleted the NODE-4014-add-let-to-bulk-write branch March 11, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@baileympearson @durran @nbbeeken @dariakp