fix(NODE-3565): Error for insertMany with partially empty array is unhelpful #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Apr 29, 2022
baileympearson
previously approved these changes
May 2, 2022
nbbeeken
changed the title
nbbeeken
requested changes
May 2, 2022
nbbeeken
previously approved these changes
May 3, 2022
dariakp
requested changes
May 3, 2022
…o check the expected error message has not been changed, fix grammar issues
baileympearson
requested changes
May 4, 2022
src/operations/insert.ts
Outdated
| if (err || res == null) { | ||
| if (err && err.message === 'Operation must be an object with an operation key') { | ||
| err = new MongoInvalidArgumentError( | ||
| 'Argument "docs" is a sparse array containing element(s) that are null or undefined' |
There was a problem hiding this comment.
Suggested change
| 'Argument "docs" is a sparse array containing element(s) that are null or undefined' | |
| 'Collection.insertMany() cannot be called with an array that has null/undefined values' |
baileympearson
previously approved these changes
May 5, 2022
nbbeeken
approved these changes
May 5, 2022
baileympearson
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-3565
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
The previous error being thrown was not descriptive.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>