feat(NODE-4185): Allow opting out of disk use on cursor builder

[lerouxb]

See also:

• https://jira.mongodb.org/browse/MONGOSH-1183
• https://jira.mongodb.org/browse/PM-2742

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[lerouxb]

I can't tell if/where to add tests.

[baileympearson]

Hey @lerouxb and @addaleax - the Node team discussed this work yesterday during our triage. The Node driver currently doesn't pass along a value for allowDiskUse if no value is specified from the user. This means that drivers changes aren't necessary for this work, because we won't be overriding the new server default with the old default. The only other work associated with this change sync the new spec tests, which due to a miscommunication and time zone differences, @kampofo completed this morning (see #3231). Sorry for the duplicated effort here but we'll close this PR and use Kobby's since the work is completed there.

[addaleax]

Talked with @baileympearson on Slack, it seems like #3231 makes this appear like something that’s already done, but in reality the tests there don’t test the builder API, only the options object API, so we do still want this 🙂

[baileympearson]

Yup. We still want to make this change, but we should add tests for the new options. I think the tests should go in find_cursor_methods.js.

As far as testing this option, we can use command monitoring on the MongoClient to ensure that the find commands contain the allowDiskUse option when they're sent to the database with the correct value.

[baileympearson]

Can we add tests for this new function? See my previous comment. I'm just requesting changes for visibility on this PR 😄