feat(NODE-4079): estimated document count uses count

[durran]

Description

Updates estimatedDocumentCount to use the count command.

What is changing?

Changes the operation to use a count command instead of an aggregate.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4079

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[durran]

Note that this commit for DRIVERS-2228 (mongodb/specifications@021cbc8) did not include all the needed test changes to get the additional tests passing. Those were part of mongodb/specifications@c430376

[baileympearson]

The spec changes say we need to document the behavior (in addition to the release notes). Should we modify the comment on Collection.estimatedDocumentCount to include the relevant information?

see https://github.com/mongodb/specifications/blob/master/source/crud/crud.rst#estimateddocumentcount

[baileympearson]

Can we also create a jira ticket and mark it for the next minor (4.7.0) with these changes, so we remember to include the relevant information in the release notes? See https://mongodb.slack.com/archives/GGWBN4ZNK/p1652725071464819

[durran]

Can we also create a jira ticket and mark it for the next minor (4.7.0) with these changes, so we remember to include the relevant information in the release notes? See https://mongodb.slack.com/archives/GGWBN4ZNK/p1652725071464819

https://jira.mongodb.org/browse/NODE-4253

[durran]

The spec changes say we need to document the behavior (in addition to the release notes). Should we modify the comment on Collection.estimatedDocumentCount to include the relevant information?

see https://github.com/mongodb/specifications/blob/master/source/crud/crud.rst#estimateddocumentcount

I've updated the TSDoc to note this and link to the MongoDB docs.

[baileympearson]

@durran

The spec changes say we need to document the behavior (in addition to the release notes). Should we modify the comment on Collection.estimatedDocumentCount to include the relevant information?
see https://github.com/mongodb/specifications/blob/master/source/crud/crud.rst#estimateddocumentcount

I've updated the TSDoc to note this and link to the MongoDB docs.

There's also this blurb from the spec:

Drivers MUST document that, due to an oversight in versions 5.0.0-5.0.8 of MongoDB, the count command, which estimatedDocumentCount uses in its implementation, was not included in v1 of the Stable API, and so users of the Stable API with estimatedDocumentCount are recommended to upgrade their server version to 5.0.9+ or set apiStrict: false to avoid encountering errors.

Should we mention this in our comment as well?

[durran]

@durran

The spec changes say we need to document the behavior (in addition to the release notes). Should we modify the comment on Collection.estimatedDocumentCount to include the relevant information?
see https://github.com/mongodb/specifications/blob/master/source/crud/crud.rst#estimateddocumentcount

I've updated the TSDoc to note this and link to the MongoDB docs.

There's also this blurb from the spec:

Drivers MUST document that, due to an oversight in versions 5.0.0-5.0.8 of MongoDB, the count command, which estimatedDocumentCount uses in its implementation, was not included in v1 of the Stable API, and so users of the Stable API with estimatedDocumentCount are recommended to upgrade their server version to 5.0.9+ or set apiStrict: false to avoid encountering errors.

Should we mention this in our comment as well?

Put in TSDoc as well now.

[durran]

These tests pass locally but fail on CI so I just rewrote them. They also weren't testing anything in some cases since any type of count would return 0 if no documents were inserted.