Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3938): Add support for pre/post images in change streams #3250

Merged
merged 9 commits into from May 18, 2022
Merged

feat(NODE-3938): Add support for pre/post images in change streams #3250

merged 9 commits into from May 18, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 17, 2022 •
edited

Description

What is changing?

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review May 17, 2022 19:21
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 18, 2022
durran
durran previously approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI errors unrelated. LGTM.

src/operations/create_collection.ts Outdated Show resolved Hide resolved
test/integration/collection-management/collection_management.spec.test.js Show resolved Hide resolved
test/spec/collection-management/createCollection-pre_and_post_images.json Show resolved Hide resolved
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 18, 2022
@nbbeeken nbbeeken self-requested a review May 18, 2022 17:24
nbbeeken
nbbeeken requested changes May 18, 2022
View reviewed changes
src/change_stream.ts Outdated Show resolved Hide resolved
src/operations/create_collection.ts Outdated Show resolved Hide resolved
@baileympearson baileympearson force-pushed the NODE-3938-change-streams-pre-post-images branch from 0bcfca4 to 8a1aa41 Compare May 18, 2022 18:06
@durran durran merged commit 981465c into main May 18, 2022
@durran durran deleted the NODE-3938-change-streams-pre-post-images branch May 18, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@baileympearson @durran @nbbeeken