Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4301): remove shared lib experimental tags #3298

Merged
merged 1 commit into from Jun 27, 2022
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jun 23, 2022

Description

Removes the experimental tags for the shared csfle library.

What is changing?

The extraOptions.cryptSharedLibPath and extraOptions.cryptSharedLibRequired provided as auto encryption options are GA and no longer experimental.

No changes to mongodb-client-encryption.

Is there new documentation needed for these changes?

Update release notes on next release to note this.

What is the motivation for this change?

NODE-4301

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review June 23, 2022 21:53
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I’m curious, since we had a long discussion about this: My understanding was that I was asked to add these in #3280 specifically because 6.0 was not GA yet. It still isn’t – what changed?

@dariakp
Copy link
Contributor

dariakp commented Jun 24, 2022

LGTM, but I’m curious, since we had a long discussion about this: My understanding was that I was asked to add these in #3280 specifically because 6.0 was not GA yet. It still isn’t – what changed?

I am also curious about this. We should probably have a team discussion, but I think the idea was that we wouldn't remove the experimental tags until we were 100% sure the api would not possibly change for the 6.0 server release; did we obtain any communication that confirmed that this API is certified stable ahead of the GA?

@durran
Copy link
Member Author

durran commented Jun 27, 2022

Yes these specific options are stable, but we can just keep this PR open if we like until we are ready to merge, but needs to be in our upcoming July release which is right around the corner.

@dariakp dariakp self-assigned this Jun 27, 2022
@dariakp dariakp added the Team Review Needs review from team label Jun 27, 2022
@dariakp dariakp merged commit 3976783 into main Jun 27, 2022
@dariakp dariakp deleted the NODE-4301 branch June 27, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
4 participants