Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4294): mark queryable encryption options beta #3300

Merged
merged 4 commits into from Jun 28, 2022
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jun 27, 2022

Description

Marks queryable encryption options as beta/Public Technical Preview.

What is changing?

Tags on the options encryptedFieldsMap and bypassQueryAnalysis. For the other encryption options see mongodb/libmongocrypt#380

Is there new documentation needed for these changes?

None.

What is the motivation for this change?

NODE-4294

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review June 27, 2022 13:37
addaleax
addaleax previously approved these changes Jun 28, 2022
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific semantic difference between @experimental and @beta? Just asking because I feel like the former is a bit more common in TS definitions and they seem to convey the same concept.

(Edit: I’m guesing from the comments in the libmongocrypt PR that this has been brought up already :))

@durran
Copy link
Member Author

durran commented Jun 28, 2022

Is there a specific semantic difference between @experimental and @beta? Just asking because I feel like the former is a bit more common in TS definitions and they seem to convey the same concept.

(Edit: I’m guesing from the comments in the libmongocrypt PR that this has been brought up already :))

Yes we decided to stay with experimental. :)

addaleax
addaleax previously approved these changes Jun 28, 2022
@nbbeeken nbbeeken merged commit 4c07bbb into main Jun 28, 2022
@nbbeeken nbbeeken deleted the NODE-4294 branch June 28, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants