New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-4385): add cmap pool pausing functionality #3321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
force-pushed
the
NODE-4385/implement-pool-pausing
branch
from
July 20, 2022 21:00
17764c1
to
4ce5cf0
Compare
dariakp
force-pushed
the
NODE-4385/implement-pool-pausing
branch
from
July 27, 2022 21:30
1605637
to
fe8417f
Compare
dariakp
force-pushed
the
NODE-4385/implement-pool-pausing
branch
2 times, most recently
from
August 26, 2022 21:59
3e9715e
to
b696513
Compare
dariakp
commented
Aug 29, 2022
dariakp
force-pushed
the
NODE-4385/implement-pool-pausing
branch
from
August 29, 2022 22:23
9334235
to
83d2a21
Compare
dariakp
force-pushed
the
NODE-4385/implement-pool-pausing
branch
from
August 31, 2022 19:39
75d48d3
to
0206e84
Compare
…ady" This reverts commit 0206e84.
dariakp
changed the title
feat: add cmap pool pausing functionality
feat(NODE-4385): add cmap pool pausing functionality
Sep 1, 2022
dariakp
added
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
and removed
wip
labels
Sep 1, 2022
dariakp
commented
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to re-review everything here and update the PR description, but it's ready for a primary review
nbbeeken
requested changes
Sep 2, 2022
test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
reviewed
Sep 2, 2022
nbbeeken
approved these changes
Sep 2, 2022
nbbeeken
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-4385 / NODE-2994
What is changing?
CMAP implementation updates
ready()
methodPoolClearedError
processWaitQueue
, as is clearing the wait queueclear
orclose
was called or happened afterwardsSDAM implementation updates
cause
property, consistent with the newcause
standard on errors in general (available in Node >16.9, so implemented manually for now, for compatibility reasons)Test updates
Is there new documentation needed for these changes?
Possibly, depends on what we currently say about the inner workings of the connection pool
What is the motivation for this change?
Avoiding connection storms
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>