fix(NODE-4425): webpack optional import of FLE issue #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
dariakp
requested changes
Jul 18, 2022
dariakp
added
the
Primary Review
From slack, decided to follow up with this: https://jira.mongodb.org/browse/NODE-4442 |
dariakp
added
Team Review
dariakp
previously approved these changes
Jul 18, 2022
src/utils.ts
Outdated
|
|
||
| // NOTE(NODE-4254): This is to get around the circular dependency between | ||
| // mongodb-client-encryption and the driver in the test scenarios. | ||
| if ( | ||
| typeof process.env.MONGODB_CLIENT_ENCRYPTION_OVERRIDE === 'string' && | ||
| process.env.MONGODB_CLIENT_ENCRYPTION_OVERRIDE.length > 0 | ||
| ) { | ||
| mongodbClientEncryption = require(process.env.MONGODB_CLIENT_ENCRYPTION_OVERRIDE); | ||
| try { | ||
| // NOTE(NODE-3199): Ensure you always wrap an optional require in the try block |
There was a problem hiding this comment.
As someone who read this comment and didn't realize that the require must literally be inside the try catch, can we update the comment to be more descriptive?
dariakp
requested changes
Jul 19, 2022
dariakp
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Move FLE require back into a try catch block.
What is the motivation for this change?
Webpack needs optional requires to be inside of a try catch.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>