Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5027): revert "ensure that MessageStream is destroyed when connections are destroyed" #3552

Merged
merged 5 commits into from Feb 7, 2023
Merged

fix(NODE-5027): revert "ensure that MessageStream is destroyed when connections are destroyed" #3552

merged 5 commits into from Feb 7, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 2, 2023 •
edited by durran

This reverts commit 8338bae.

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title fix(NODE-5027): revert "ensure that MessageStream is destroyed when connections are destroyed (#3482)" fix(NODE-5027): revert "ensure that MessageStream is destroyed when connections are destroyed" Feb 2, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 6, 2023
@durran
Copy link
Member

durran commented Feb 6, 2023

KMS TLS failures in NODE-5033

durran
durran approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 6, 2023
@durran durran merged commit 2d178d0 into main Feb 7, 2023
@durran durran deleted the NODE-5027-revert-8338bae933-main branch February 7, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
2 participants
@nbbeeken @durran