Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5034): support OIDC auth options #3557

Merged
merged 7 commits into from Feb 8, 2023
Merged

feat(NODE-5034): support OIDC auth options #3557

merged 7 commits into from Feb 8, 2023

Conversation

durran
Copy link
Member

@durran durran commented Feb 6, 2023 •
edited

Description

Add support for OIDC connection string and MongoClient options.

Reference PR: mongodb/specifications#1365

What is changing?

  • Syncs all the new auth spec tests and moves them to the legacy folder.
  • Adds PRINCIPAL_NAME, DEVICE_NAME, REQUEST_TOKEN_CALLBACK and REFRESH_TOKEN_CALLBACK auth mechanism properties and types.
  • Handles all the new OIDC option validation.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5034/DRIVERS-2415

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title Node 5034 feat(NODE-5034): support OIDC auth options Feb 6, 2023
@durran durran added the wip label Feb 6, 2023
@durran durran removed the wip label Feb 6, 2023
@durran durran marked this pull request as ready for review February 6, 2023 21:33
@durran durran force-pushed the NODE-5034 branch 2 times, most recently from bc8aa39 to d09a60e Compare February 6, 2023 22:02
nbbeeken
nbbeeken requested changes Feb 7, 2023
View reviewed changes
src/cmap/auth/mongodb_oidc.ts Outdated Show resolved Hide resolved
src/cmap/auth/mongo_credentials.ts Outdated Show resolved Hide resolved
src/cmap/auth/mongo_credentials.ts Outdated Show resolved Hide resolved
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 7, 2023
@durran durran requested a review from nbbeeken February 7, 2023 20:40
nbbeeken
nbbeeken approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@durran durran requested a review from nbbeeken February 7, 2023 22:12
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 7, 2023
nbbeeken
nbbeeken requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript publicness fixes

src/cmap/auth/mongodb_oidc.ts Outdated Show resolved Hide resolved
src/cmap/auth/mongo_credentials.ts Outdated Show resolved Hide resolved
src/cmap/auth/providers.ts Outdated Show resolved Hide resolved
@durran durran requested a review from nbbeeken February 8, 2023 18:15
nbbeeken
nbbeeken previously approved these changes Feb 8, 2023
View reviewed changes
@nbbeeken nbbeeken merged commit 20a4fec into main Feb 8, 2023
@nbbeeken nbbeeken deleted the NODE-5034 branch February 8, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
2 participants
@durran @nbbeeken