feat(NODE-5050): support GCP automatic credential fetch for CSFLE #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5050-gcp-int-tests
branch
2 times, most recently
from
7dd92ef
to
d2e92fc
Compare
nbbeeken
force-pushed
the
NODE-5050-gcp-int-tests
branch
from
d2e92fc
to
d0064a7
Compare
baileympearson
added
the
Primary Review
baileympearson
requested changes
Feb 17, 2023
| @@ -663,6 +663,13 @@ BUILD_VARIANTS.push({ | |||
| tasks: ['serverless_task_group'] | |||
| }); | |||
|
|
|||
| BUILD_VARIANTS.push({ | |||
| name: 'rhel8-test-gcp-kms', | |||
| display_name: 'GCP KMS Test', | |||
There was a problem hiding this comment.
Suggested change
| display_name: 'GCP KMS Test', | |
| display_name: 'FLE KMS Refresh Tests', |
we will soon have both AWS and Azure as well - maybe we can just have a generic task group?
There was a problem hiding this comment.
I don't think you'll be able to reuse this variant, it's specific to GCP / GCP setup scripts. I tried to use the scripts on our typical rhel8 setup but it fails, it needs to be on debian11, so azure might have a diff config too (windows? 😱)
| echo "${testgcpkms_key_file}" > ./testgcpkms_key_file.json | ||
| export GCPKMS_KEYFILE=./testgcpkms_key_file.json | ||
|
|
||
| "$GCPKMS_DRIVERS_TOOLS/.evergreen/csfle/gcpkms/create-and-setup-instance.sh" |
There was a problem hiding this comment.
Perhaps dumb question – does this task also start a server? And is that server always a standalone?
There was a problem hiding this comment.
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
baileympearson
approved these changes
Feb 21, 2023
baileympearson
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
test-gcpkms-taskthat uploads the driver to a GCP instance and runs success testtest-gcpkms-fail-taskthat runs locally on EVG and tests for failure{accessToken:string}types toazureandgcpcredential types{}empty credential types toawsandgcpWhat is the motivation for this change?
Support GCP KMS auto credential fetching.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript