fix(NODE-3998): metadata duplication in handshake #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
nbbeeken
requested changes
Mar 29, 2023
nbbeeken
added
the
Primary Review
nbbeeken
changed the title
baileympearson
commented
Mar 29, 2023
| @@ -526,13 +529,14 @@ export interface ClientMetadata { | |||
| version: string; | |||
| }; | |||
| platform: string; | |||
There was a problem hiding this comment.
This was wrong, according to the spec: https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#hello-command
this modifies a public interface but it's also technically a bug fix, so I think it's okay to remove
nbbeeken
requested changes
Mar 29, 2023
nbbeeken
previously approved these changes
Mar 30, 2023
nbbeeken
added
Team Review
nbbeeken
previously approved these changes
Mar 30, 2023
|
evergreen retry |
W-A-James
requested changes
Mar 31, 2023
Co-authored-by: Warren James <warren.james.dev@gmail.com>
baileympearson
force-pushed
the
NODE-3998-2
branch
from
e64b5f8
to
5f2e229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR prevents metadata duplication in the handshake. To do this, it removes custom transforms for the driverInfo and appName options and constructs the metadata once at the end of options parsing.
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript