fix(NODE-5042): relax SRV record validation to account for a dot suffix #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5042-srv-dot
branch
from
eb8e384
to
70ce937
Compare
durran
added
the
Primary Review
durran
requested changes
Apr 11, 2023
addaleax
previously requested changes
Apr 11, 2023
addaleax
reviewed
Apr 11, 2023
addaleax
approved these changes
Apr 11, 2023
durran
added
Team Review
durran
approved these changes
Apr 12, 2023
W-A-James
pushed a commit
that referenced
this pull request
Apr 12, 2023
baileympearson
pushed a commit
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Allows for SRV record addresses to have a trailing dot
Verified manually that this makes deno connect successfully with an SRV record.
To reproduce my success: 😎
deno initimport { MongoClient } from 'mongodb'deno run --inspect-brk --allow-read --allow-sys --allow-env --allow-net main.tsnpm pack-ed this branch and replaced the folder here:node_modules/.deno/mongodb@5.2.0/node_modules/mongodbWhat is the motivation for this change?
A trailing dot on a hostname does not prevent dns.lookup resolution so our validation can be made more lenient.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript