Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4970): deprecate collStats collection helper #3638

Merged
merged 11 commits into from Apr 21, 2023
Merged

feat(NODE-4970): deprecate collStats collection helper #3638

merged 11 commits into from Apr 21, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Apr 13, 2023 •
edited by dariakp

Description

What is changing?

POC for drivers-2232.

  • The unified test runner has been updated to support the createOptions option for initialData
  • Syncs spec tests that use collStats (from corresponding specs PR)
  • Any driver code related to the collStats command is deprecated for removal
Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title add collstats test feat(NODE-4970): deprecate collStats collection helper Apr 13, 2023
@baileympearson baileympearson mentioned this pull request Apr 13, 2023
Merged
4 tasks
@baileympearson baileympearson marked this pull request as ready for review April 13, 2023 17:24
@durran durran self-assigned this Apr 17, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 17, 2023
durran
durran previously approved these changes Apr 17, 2023
View reviewed changes
@durran durran removed their assignment Apr 17, 2023
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 17, 2023
nbbeeken
nbbeeken previously approved these changes Apr 17, 2023
View reviewed changes
@dariakp dariakp requested review from a team, jyemin and dariakp and removed request for a team and jyemin April 17, 2023 18:26
dariakp
dariakp requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for mongodb/specifications#1402 to merge

@nbbeeken nbbeeken added the Blocked Blocked on other work label Apr 17, 2023
@baileympearson baileympearson dismissed stale reviews from nbbeeken and durran via 09df3db April 18, 2023 18:53
@dariakp dariakp removed the Blocked Blocked on other work label Apr 19, 2023
durran
durran previously approved these changes Apr 19, 2023
View reviewed changes
@durran durran requested a review from dariakp April 19, 2023 15:10
dariakp
dariakp requested changes Apr 19, 2023
View reviewed changes
src/operations/stats.ts Outdated Show resolved Hide resolved
src/operations/stats.ts Show resolved Hide resolved
@baileympearson
Copy link
Contributor Author

evergreen help

@evrg-bot-webhook
Copy link

Available Evergreen Comment Commands

  • evergreen retry - attempts to create a new PR patch; this is useful when something went wrong with automatically creating PR patches
  • evergreen refresh - resyncs PR GitHub checks

@durran durran merged commit 325c4bc into main Apr 21, 2023
13 of 17 checks passed
@durran durran deleted the NODE-4970-deprecate-collstats branch April 21, 2023 15:20
@ccho-mongodb ccho-mongodb mentioned this pull request Aug 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@dariakp dariakp dariakp approved these changes

@nbbeeken nbbeeken Awaiting requested review from nbbeeken

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
5 participants
@baileympearson @evrg-bot-webhook @durran @nbbeeken @dariakp