Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5201): prevent warning when default value for deprecation option is used #3646

Merged
merged 4 commits into from Apr 18, 2023
Merged

fix(NODE-5201): prevent warning when default value for deprecation option is used #3646

merged 4 commits into from Apr 18, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Apr 17, 2023 •
edited

Description

What is changing?

  • Default options are no longer collected as a part of the allOptions map. Since allOptions no longer contains defaults, it is now named providedOptions
  • deprecation warnings are emitted inside parseOptions, not setOption, and are only emitted for non-default values
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title fix(NODE-5159): prevent warning when default value for deprecation option is used fix(NODE-5201): prevent warning when default value for deprecation option is used Apr 17, 2023
@nbbeeken nbbeeken self-assigned this Apr 17, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 17, 2023
nbbeeken
nbbeeken requested changes Apr 17, 2023
View reviewed changes
src/connection_string.ts Outdated Show resolved Hide resolved
src/connection_string.ts Outdated Show resolved Hide resolved
test/unit/mongo_client.test.js Show resolved Hide resolved
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 17, 2023
@nbbeeken nbbeeken merged commit e7f6e4e into main Apr 18, 2023
14 of 21 checks passed
@nbbeeken nbbeeken deleted the NODE-5159 branch April 18, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@baileympearson @durran @nbbeeken