Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5166): bump max wire version for 7.0 #3659

Merged
merged 2 commits into from May 4, 2023

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented May 3, 2023

Description

NODE-5166 / DRIVERS-2595

What is changing?

Bumps the wire version to 21 and the max supported server version to 7.0 (this only impacts the error message if the driver is used with a server whose min wire version is above 21, not any driver functionality) and updates relevant tests.

Is there new documentation needed for these changes?

No, because we only update compat tables at release time.

What is the motivation for this change?

Future proofing

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket N/A

@dariakp
Copy link
Contributor Author

dariakp commented May 3, 2023

Failures are unrelated to changes (known aws 404 issue, a new fle setup issue, and a couple of known flakes)

@dariakp dariakp marked this pull request as ready for review May 3, 2023 22:37
@durran durran added the Team Review Needs review from team label May 4, 2023
@durran durran merged commit 561229b into main May 4, 2023
1 of 2 checks passed
@durran durran deleted the NODE-5166/bump-max-wire-version-to-21 branch May 4, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
3 participants