Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5004): dont create or drop ecc collections #3660

Merged
merged 5 commits into from May 5, 2023
Merged

feat(NODE-5004): dont create or drop ecc collections #3660

merged 5 commits into from May 5, 2023

Conversation

durran
Copy link
Member

@durran durran commented May 4, 2023 •
edited by nbbeeken

Description

Does not create or drop ecc collections when using QEv2.

What is changing?

  • No longer creates ecc collection during create collection.
  • No longer drops ecc collection during drop.
  • Throws an error when server < 7.0 when encrypted fields supplied.
  • Syncs to NODE-5195 de-dup FLE tests.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5004/NODE-5195

Backported: #3678

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran
Copy link
Member Author

durran commented May 4, 2023

Failures in CI unrelated to these changes, CSFLE all passing here: https://spruce.mongodb.com/version/6453b7cf57e85ab511b55d44/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&variant=%5Erhel8-custom-dependency-tests%24

@durran durran marked this pull request as ready for review May 4, 2023 14:17
addaleax
addaleax previously approved these changes May 4, 2023
View reviewed changes
src/operations/create_collection.ts Show resolved Hide resolved
@nbbeeken nbbeeken self-assigned this May 4, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 4, 2023
nbbeeken
nbbeeken requested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change about server version, mentioned an improvement if we want that as well

src/operations/create_collection.ts Show resolved Hide resolved
src/operations/create_collection.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 4, 2023
nbbeeken
nbbeeken previously approved these changes May 4, 2023
View reviewed changes
@nbbeeken nbbeeken merged commit 2264fbb into main May 5, 2023
18 of 21 checks passed
@nbbeeken nbbeeken deleted the NODE-5004 branch May 5, 2023 15:47
baileympearson pushed a commit that referenced this pull request May 19, 2023
@durran @baileympearson
feat(NODE-5004): dont create or drop ecc collections (#3660)
f0a46ee
@nbbeeken nbbeeken mentioned this pull request May 24, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@durran @addaleax @nbbeeken