Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jest to latest version #591

Closed
guumaster opened this issue Mar 17, 2022 · 2 comments
Closed

update jest to latest version #591

guumaster opened this issue Mar 17, 2022 · 2 comments
Labels

Comments

@guumaster
Copy link
Member

when using jest@latest (currently v27) test suites brake with this error:

 Test functions cannot both take a 'done' callback and return something. Either use a 'done' callback, or return a promise.

several tests needs to be reviewed.

@yahiakr
Copy link
Collaborator

yahiakr commented Mar 17, 2022

The new 27.x version does not support done callback and async test simultaneously (see this: jestjs/jest#10529).

As we are using both of them in event-based tests (e.g: to test synchronize method), we need to refactor those them so we can test those methods with one of the two (done callback or async).

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2022
@yahiakr yahiakr closed this as completed Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants