Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linting functionality #221

Open
stherold opened this issue Oct 6, 2023 · 6 comments
Open

Add a linting functionality #221

stherold opened this issue Oct 6, 2023 · 6 comments

Comments

@stherold
Copy link

stherold commented Oct 6, 2023

Since you already did a great job finding all licenses (Kudos), it would be easy to also verify that the dependencies all have licenses that wre whitelisted somewhere. Somewhere could be in the config file or a separate file.

I got the idea from here which uses decision files similar to the one blelow to lint licenses. But that tool doesn't seem to work properly with iOS dependency managers.

Example Decision File

---
- - :permit
  - MIT
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-07-27 07:50:57.411184000 Z
- - :permit
  - ruby
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-07-27 07:51:08.681913000 Z
- - :permit
  - Apache 2.0
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-07-27 07:51:14.222256000 Z
- - :permit
  - BSD
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-08-02 20:10:55.731775981 Z
- - :permit
  - New BSD
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-08-02 20:10:55.731775981 Z
- - :permit
  - Simplified BSD
  - :who: blackjacx
    :why:
    :versions: []
    :when: 2023-08-02 20:11:03.882864297 Z
@stherold
Copy link
Author

Do you think this is an addition that could make it into LicensePlist?

@mono0926
Copy link
Owner

@stherold

Thank you for your suggestion.
However, I feel it is out of the scope of the functionality this tool should provide 🤔

@stherold
Copy link
Author

Okay thanks for the information. We will then use one of the export options to get the detected licenses by LicensePlist and write a script to do that task on our side.

One question though, what do you think about a JSON export option since that is easier to parse as the tooling is more popular than with CSV.

@mono0926
Copy link
Owner

@stherold

One question though, what do you think about a JSON export option since that is easier to parse as the tooling is more popular than with CSV.

I think it is nice to have feature 👍

@stherold
Copy link
Author

Should we keep it in this ticket or open a new one?

@mono0926
Copy link
Owner

@stherold

I've closed this issue.
You can create a pull request directly without an issue for CSV option support 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants