Allow PHP 8 #32
Open
Allow PHP 8 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07f90a9.
I erred when reverting the introducing of Nyholm's PSR-7 factory.
|
Travis succeeds with PHP 7.2 and PHP 7.4; seems it has issues with the test config for PHP 7.3. Can someone have a look? https://travis-ci.com/github/monolog-http/monolog-http/jobs/508155473 |
|
@tomkyle looks like a similar issue to https://stackoverflow.com/a/65198478 - can you check if that fixes the build? |
|
It would be great to include PHP 8.1 at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #31 . Contrary to the initial issue description, using Nyholm's PSR-7 factory (as proposed in my fork) is not longer needed as Guzzle 1.7+ has added support for PHP 8 as well.