Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyse vimeo/psalm 5.20 and up (now sticky to 5.19.x) #279

Open
stronk7 opened this issue Mar 7, 2024 · 0 comments
Open

Analyse vimeo/psalm 5.20 and up (now sticky to 5.19.x) #279

stronk7 opened this issue Mar 7, 2024 · 0 comments
Labels
task Some task to complete

Comments

@stronk7
Copy link
Member

stronk7 commented Mar 7, 2024 •
edited

Because vimeo/psalm 5.20 comes with some new (crazy?) RiskyTruthyFalsyComparison checks that are impacting us a lot, we have changed the dev requirements to use vimeo/psalm 5.19 instead.

This is the PR that introduced the new checks: vimeo/psalm#10502, for examples and friends.

This issue is about to analyse the impact of that new check and decide about to disable it or go fixing all the cases it's reporting (some of them look like "too-much" pedantic, IMO).

For example, see this run using the newer 5.20 version: https://github.com/stronk7/moodle-plugin-ci/actions/runs/8191901373

Ciao :-)
@stronk7 stronk7 added the task Some task to complete label Mar 7, 2024
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Mar 7, 2024
@stronk7
Bump various dependencies
320cea2 
- moodle-cs 3.4.0
- moodle-local_moodlecheck 1.3.0
- moodle-local_ci 1.0.28
- php-compatibility e5cd2e24

It also comes with a good number of updates in
dev tools and other dependencies.

Note that we have had to stay sticky to vimeo/psalm 5.19.*
because 5.20 comes with some new RiskyTruthyFalsyComparison
problems that we need to analyse. This issue has been created
about that: moodlehq#279
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Mar 8, 2024
@stronk7
Bump various dependencies
0ba289f 
- moodle-cs 3.4.1
- moodle-local_moodlecheck 1.3.0
- moodle-local_ci 1.0.28
- php-compatibility e5cd2e24

It also comes with a good number of updates in
dev tools and other dependencies.

Note that we have had to stay sticky to vimeo/psalm 5.19.*
because 5.20 comes with some new RiskyTruthyFalsyComparison
problems that we need to analyse. This issue has been created
about that: moodlehq#279
mchurchward pushed a commit to brickfield/moodle-plugin-ci that referenced this issue May 30, 2024
@stronk7 @mchurchward
Bump various dependencies
d965f82 
- moodle-cs 3.4.1
- moodle-local_moodlecheck 1.3.0
- moodle-local_ci 1.0.28
- php-compatibility e5cd2e24

It also comes with a good number of updates in
dev tools and other dependencies.

Note that we have had to stay sticky to vimeo/psalm 5.19.*
because 5.20 comes with some new RiskyTruthyFalsyComparison
problems that we need to analyse. This issue has been created
about that: moodlehq/moodle-plugin-ci#279
mchurchward pushed a commit to brickfield/moodle-plugin-ci that referenced this issue May 30, 2024
@stronk7 @mchurchward
Bump various dependencies
e3c6bd7 
- moodle-cs 3.4.1
- moodle-local_moodlecheck 1.3.0
- moodle-local_ci 1.0.28
- php-compatibility e5cd2e24

It also comes with a good number of updates in
dev tools and other dependencies.

Note that we have had to stay sticky to vimeo/psalm 5.19.*
because 5.20 comes with some new RiskyTruthyFalsyComparison
problems that we need to analyse. This issue has been created
about that: moodlehq/moodle-plugin-ci#279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Some task to complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stronk7