Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify OAuth token includes required scopes #42

Open
moollaza opened this issue Oct 31, 2019 · 0 comments
Open

Verify OAuth token includes required scopes #42

moollaza opened this issue Oct 31, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@moollaza
Copy link
Owner

Background

TheTokenForm currently validates the token by making an API call to see if GitHub responds with a user, but it doesn't verify the token has the required scopes.

Without the requires scopes (repo, delete_repo) the user will not be able to archive/delete any repos.

Solution

Find a way to check the X-OAuth-Scopes header in the API response, inside TheTokenForm.vue. It should contain delete_repo, repo
@moollaza moollaza added enhancement New feature or request good first issue Good for newcomers labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moollaza