Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to polkadot v0.9.24 #66

Closed
DappGuy opened this issue Jul 4, 2022 · 7 comments
Closed

update to polkadot v0.9.24 #66

DappGuy opened this issue Jul 4, 2022 · 7 comments

Comments

@DappGuy
Copy link

DappGuy commented Jul 4, 2022

We are using nimbus in our hackathon project and we must use the latest polkadot version. is it possible to get a v0.9.24 branch or should we do it ourselves? :)

@crystalin
Copy link
Collaborator

At the current moment, it would be easier to provide a PR for it as the Moonbeam team is currently focus on v0.9.23 compatibility.
I don't think there is a lot of changes in v0.9.24 so it shouldn't be too complex

@DappGuy
Copy link
Author

DappGuy commented Jul 5, 2022

Understood, thanks for the fast response

@ghzlatarev
Copy link
Contributor

At the current moment, it would be easier to provide a PR for it as the Moonbeam team is currently focus on v0.9.23 compatibility.
I don't think there is a lot of changes in v0.9.24 so it shouldn't be too complex

I can do that, we also need 0.9.24. Just not sure if I should branch off main or the 0.9.23 branch @crystalin

@notlesh
Copy link
Contributor

notlesh commented Jul 15, 2022

At the current moment, it would be easier to provide a PR for it as the Moonbeam team is currently focus on v0.9.23 compatibility.
I don't think there is a lot of changes in v0.9.24 so it shouldn't be too complex

I can do that, we also need 0.9.24. Just not sure if I should branch off main or the 0.9.23 branch @crystalin

We start from main and preferably merge back in when done, so I would suggest opening a PR when you've gotten started.

Thanks!

@notlesh
Copy link
Contributor

notlesh commented Jul 15, 2022

It looks like there is a significant diff between main and moonbeam-polkadot-v0.9.23 (our latest dependency update branch), so you may want to either:

  • start from main and reference moonbeam-polkadot-v0.9.23 changes to help you
  • start from moonbeam-polkadot-v0.9.23 and remove the irrelevant parts (esp. branch / repo changes in Cargo.toml files).

(CC @librelois)

@ghzlatarev
Copy link
Contributor

It looks like there is a significant diff between main and moonbeam-polkadot-v0.9.23 (our latest dependency update branch), so you may want to either:

  • start from main and reference moonbeam-polkadot-v0.9.23 changes to help you
  • start from moonbeam-polkadot-v0.9.23 and remove the irrelevant parts (esp. branch / repo changes in Cargo.toml files).

(CC @librelois)

Thanks for the pointer, here's the PR #68
Btw I noticed that in the moonbeam-polkadot-v0.9.23 branch the cumulus dependency is using your own fork, but in main the Cumulus are using Parity repo like the other dependencies. So I wasn't sure which one to use.

@librelois
Copy link
Contributor

Btw I noticed that in the moonbeam-polkadot-v0.9.23 branch the cumulus dependency is using your own fork, but in main the Cumulus are using Parity repo like the other dependencies. So I wasn't sure which one to use.

Thank you @ghzlatarev for your help :)

You should use the official cumulus release, we use a custom fork for specific moonbeam needs, because we need changes not merged upstream yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants