Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checked arithmetic operations for Int and Int64 #244

Closed
wants to merge 1 commit into from
Closed

Add checked arithmetic operations for Int and Int64 #244

wants to merge 1 commit into from

Conversation

yj-qin
Copy link
Collaborator

@yj-qin yj-qin commented Apr 12, 2024 •
edited by coderabbitai bot

Closes #241

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Introduced safe arithmetic operations for integers, including absolute value, negation, addition, subtraction, multiplication, and division, with overflow handling.

@yj-qin yj-qin requested a review from bobzhang April 12, 2024 02:30
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 12, 2024 •
edited

Walkthrough

The update implements checked arithmetic operations for Int and Int64 data types, ensuring safe handling of potential arithmetic overflows with the use of Option types. This includes functions for absolute value, negation, addition, subtraction, multiplication, and division.

Changes

Files Change Summary
int/int.mbt, int64/... New functions added for checked arithmetic operations (checked_abs, checked_neg, checked_add, checked_sub, checked_mul, checked_div)

Assessment against linked issues

Objective Addressed Explanation
Checked arithmetic operations for Int and Int64 (#241) ✅
Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d7da7cc and efb019c.
Files selected for processing (2)
  • int/int.mbt (2 hunks)
  • int64/int64.mbt (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • int/int.mbt
  • int64/int64.mbt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Lampese Lampese added the review-needed Pull requests that require a review. label Apr 12, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (d7da7cc) to head (efb019c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   82.83%   83.15%   +0.31%     
==========================================
  Files          50       50              
  Lines        2208     2244      +36     
==========================================
+ Hits         1829     1866      +37     
+ Misses        379      378       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yj-qin yj-qin changed the title feat: checked arithmetic operations for Int and Int64 Add checked arithmetic operations for Int and Int64 Apr 19, 2024
@yj-qin yj-qin closed this May 22, 2024
@yj-qin yj-qin deleted the checked-op branch May 22, 2024 06:08
@yj-qin yj-qin restored the checked-op branch May 22, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzhang bobzhang Awaiting requested review from bobzhang

Assignees
No one assigned
Labels
review-needed Pull requests that require a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: checked arithmetic operations for Int and Int64
2 participants
@yj-qin @Lampese