Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: rename Bytes::to_string to Bytes::to_string_unchecked #291

Open
lijunchen opened this issue Apr 19, 2024 · 1 comment · May be fixed by #384
Open

Proposal: rename Bytes::to_string to Bytes::to_string_unchecked #291

lijunchen opened this issue Apr 19, 2024 · 1 comment · May be fixed by #384
Assignees
@Yoorkin
Labels
proposal

Comments

@lijunchen
Copy link
Contributor

  • Add a new method Bytes::to_string_unchecked that behaves the same as the current Bytes::to_string.
  • Change the behavior of Bytes::to_string to output bytes literal or bytes array.

Related: #257
@bobzhang
Copy link
Contributor

We should add bytes literal syntax,e.g, b"xx.." and use make Byte::to_string confirm to the format

@Yoorkin Yoorkin linked a pull request May 13, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yoorkin Yoorkin

Labels
proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refine behavior of Bytes::to_string moonbitlang/core
4 participants
@bobzhang @Yoorkin @yj-qin @lijunchen