Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize containers (like hashmap, mutable_map, etc) into a dedicated collections folder #342

Open
jialunzhang-psu opened this issue Apr 28, 2024 · 0 comments
Labels

Comments

@jialunzhang-psu
Copy link
Collaborator

Motivations

  • The list of packages in core is getting lengthy.
  • After putting different containers into a separate collections folder, it becomes more convenient to share implementation between containers. For example, hashmap and hashset share the same underlying Robin Hood hashing. mutable_set and mutable_map can share the red-black tree implementation. Maintaining just one copy of the implementation reduces redundant code and tests.

Concern

  • Suppose we have hashmap, hashset and robinhood_hash, three packages under the collections folder, while hashmap and hashset rely on robinhood_hash. How to make robinhood_hash invisible to the outside?

A potential PR is #324.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants