Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO list #50

Open
16 of 25 tasks
bobzhang opened this issue Mar 13, 2024 · 10 comments
Open
16 of 25 tasks

TODO list #50

bobzhang opened this issue Mar 13, 2024 · 10 comments

Comments

@bobzhang
Copy link
Contributor

bobzhang commented Mar 13, 2024

  • xxhash for primitive types
    ref https://github.com/jungomi/xxhash-wasm
  • linked hashmap which preserve insertion order when iteration
  • add as_iter for each data structure
  • coverage > 95%
  • map
  • set
  • hashmap
  • hashset
  • efficient hash function for built in type
  • json
  • json5
    // this may be a good example to showcase moonbit's perf over handwritten js
  • mutable map // mutable map
  • mutable set
  • array missing method
    • sort
    • stable sort
  • README.md for each package
  • random
  • strconv
  • move most builtin utilities to its belonged package
    • float ryu
    • buffer
  • rational
  • bigint
  • persistent vector
@DiamondMofeng
Copy link
Contributor

DiamondMofeng commented Mar 15, 2024

How about adding BinaryHeap👀

@bobzhang
Copy link
Contributor Author

@DiamondMofeng contributions are welcome

@zxch3n
Copy link
Contributor

zxch3n commented Mar 17, 2024

Just created a PR for sort #72

@Yoorkin
Copy link
Collaborator

Yoorkin commented Mar 18, 2024

#53 implemented some basic operations for the tree-based map.
Some methods are still missing:

  • filter, map, map_with_key, fold, iteri
  • Extraction methods like elems, keys, to_vec, to_array
  • (Map,Map) -> Map methods like union, difference, intersection

@peter-jerry-ye
Copy link
Contributor

peter-jerry-ye commented Mar 27, 2024

  • reserve_capacity and shrink_to_fit for vector/deque

@peter-jerry-ye
Copy link
Contributor

  • time api (may be an API similar to Java with LocalDate LocalTime LocalDateTime and ZonedDateTime

@He1pa
Copy link
Contributor

He1pa commented Apr 11, 2024

stable sort #225

@fantix
Copy link
Contributor

fantix commented Apr 13, 2024

Another reference for the time API: https://docs.edgedb.com/database/stdlib/datetime

@lgxbslgx
Copy link
Contributor

If I want to claim a task you listed above, I need to read all the PRs and judge which task is been reviewing now. Also, I don't know which task has been already started by someone locally. So I suggest that all the tasks should have their own issues (so that the developers can assign them clearly) and link them in this issue. For example ( json and json5)

@jialunzhang-psu
Copy link
Collaborator

jialunzhang-psu commented Apr 26, 2024

For full coverage, we need to resolve an issue mentioned in #223, i.e., unreachable statements for exhaustiveness of pattern matching shouldn't be counted towards missing coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants