Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalized events for ie7/8 for checkboxes and radios fires bound events on propertychange #2352

Open
DimitarChristoff opened this issue Apr 17, 2012 · 5 comments · May be fixed by #2704
Open

normalized events for ie7/8 for checkboxes and radios fires bound events on propertychange #2352

DimitarChristoff opened this issue Apr 17, 2012 · 5 comments · May be fixed by #2704
Labels
bug
Milestone
1.5.3

Comments

@DimitarChristoff
Copy link
Member

DimitarChristoff commented Apr 17, 2012 •
edited by arian

check this fiddle:

http://jsfiddle.net/8VMQs/1/

basically, i'd expect when doing element.set('checked', true); the change event bound NOT to fire automatically.
observed: event fires.

i am trying to find a way to differentiate the event from a UI driven event (eg, one that is a result of a click) but there is nothing in it, it's just propertychange bubbling to change.

relevant bit: https://github.com/mootools/mootools-core/blob/master/Source/Element/Element.Event.js#L170-183

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/55897-normalized-events-for-ie7-8-for-checkboxes-and-radios-fires-bound-events-on-propertychange?utm_campaign=plugin&utm_content=tracker%2F22067&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F22067&utm_medium=issues&utm_source=github).
@arian
Copy link
Member

arian commented Apr 19, 2012

Also here is another problem described, when you change input.checked in the change event: http://allbtechebooks.blogspot.com/2012/04/mootools-event-causes-infinite-loop-in.html

/cc @csuwldcat

@DimitarChristoff
Copy link
Member Author

They ripped off SO - orig here:
http://stackoverflow.com/questions/10182381/mootools-event-causes-infinite-loop-in-ie7-ie8-
its what prmpted me to raise the bug.
On Apr 19, 2012 7:33 PM, "Arian Stolwijk" <
reply@reply.github.com>
wrote:

Also here is another problem described, when you change input.checked in
the change event:
http://allbtechebooks.blogspot.com/2012/04/mootools-event-causes-infinite-loop-in.html

/cc @csuwldcat

Reply to this email directly or view it on GitHub:
#2352 (comment)

@arian
Copy link
Member

arian commented Apr 19, 2012

Ah, I found it via twitter..

@arian
Copy link
Member

arian commented Aug 8, 2012

@csuwldcat this is your thing i guess..

@ibolmo ibolmo modified the milestones: 1.5.1, 1.5 Mar 3, 2014
@ibolmo
Copy link
Member

ibolmo commented Jul 3, 2014

pinging @csuwildcat once more

@SergioCrisostomo SergioCrisostomo modified the milestones: 1.5.2, 1.5.1 Jul 20, 2014
@SergioCrisostomo SergioCrisostomo linked a pull request Mar 11, 2015 that will close this issue
Open
@SergioCrisostomo SergioCrisostomo modified the milestones: 1.5.2, 1.5.3 Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.5.3
Development

Successfully merging a pull request may close this issue.

normalize IE8 input checked setter SergioCrisostomo/mootools-core
4 participants
@ibolmo @arian @DimitarChristoff @SergioCrisostomo