Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate into Parser, Finder and Attribute #53

Open
arian opened this issue Sep 15, 2011 · 8 comments
Open

Separate into Parser, Finder and Attribute #53

arian opened this issue Sep 15, 2011 · 8 comments
Assignees

Comments

@arian
Copy link
Member

arian commented Sep 15, 2011

Create three AMD modules for:

  • Finder
  • Parser
  • Attribute

This way a DOM library can just pick which parts they want: parsing for new Element('div.foo[attr=bar]') or using Slick.getAttribute but use QSA instead of Finder.

@cpojer
Copy link
Member

cpojer commented Sep 16, 2011

Hey. It is called Attribute.

@Inviz
Copy link

Inviz commented Sep 16, 2011

Are you sure about using the shortcut name "Attr" when virtually no place in DOM has it that way?

@Inviz
Copy link

Inviz commented Sep 16, 2011

Except jQuery (because DOM IS A MESS)

@cpojer
Copy link
Member

cpojer commented Sep 16, 2011

We settled this already :D

@Inviz
Copy link

Inviz commented Sep 17, 2011

I typed in the comment but forget to press comment, but when i started typing i was first!

@ghost ghost assigned subtleGradient Sep 23, 2011
@arian
Copy link
Member Author

arian commented Sep 26, 2011

There should be a uidOf module too. This is used a couple of times in the DOM package.

@Inviz
Copy link

Inviz commented Sep 26, 2011

I like where it goes with Specificity

@totty90
Copy link

totty90 commented Apr 10, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants