Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that no deprecation warnings are thrown in FF (getAttributeNode) #61

Open
schnix opened this issue Oct 2, 2011 · 3 comments
Open
Assignees
Labels

Comments

@schnix
Copy link

schnix commented Oct 2, 2011

both functions are deprecated in DOM4.

refering to: https://developer.mozilla.org/en/DOM/Attr

jsfiddle:
http://jsfiddle.net/schnix/9agrB/

ff7 throws a warning
ie7 throws an error

havent installed more browsers atm

schnix

@arian
Copy link
Member

arian commented Oct 2, 2011

FF7 works fine for me..

@subtleGradient
Copy link
Member

Node.getAttributeNode is not deprecated. Attr.getAttributeNode is deprecated.

e.g. el.getAttributeNode('foo').getAttributeNode

It's likely warning because Attr.specified is also deprecated.

We definitely should stop Firefox from showing a warning if possible. The trick is to do that with a feature test and not sniff the UA string or whatever. Using Attr.specified is absolutely essential in some browsers.

@ghost ghost assigned fabiomcosta Mar 12, 2012
@garyee
Copy link

garyee commented Mar 11, 2015

The Problem is still there... (using 1.5.5 and FF 36.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants