Should not allow to create File with different SCC codes in Batch Header and Batch Control

[nazeer1100126]

Looks like there is no validation on Batch Control SCC code. Even I can pass some random integer.
But NACHA file is created having Batch Control SCC code equal to Batch Header SCC code

ACH Version: master

What were you trying to do?

What did you expect to see?

What did you see?

How can we reproduce the problem?

[adamdecaf]

But NACHA file is created having Batch Control SCC code equal to Batch Header SCC code

It sounds like the SCC code is correctly fixed. I'm not sure what the bug is here. We're creating a valid file from invalid input, which is good.

[nazeer1100126]

I see the below logic in batch.go, I assume it is mandating the both SCC codes should be equal. But actually it is not mandating as mentioned in this ticket.

if !batch.IsADV() {
		// validate batch header and control codes are the same
		if (batch.validateOpts == nil || !batch.validateOpts.UnequalServiceClassCode) &&
			**batch.Header.ServiceClassCode != batch.Control.ServiceClassCode {
			return batch.Error("ServiceClassCode",
				NewErrBatchHeaderControlEquality(batch.Header.ServiceClassCode, batch.Control.ServiceClassCode))
		}**
		// Company Identification in the batch header and control must match if bypassCompanyIdentificationMatch is not enabled.
		if batch.Header.CompanyIdentification != batch.Control.CompanyIdentification &&
			!(batch.validateOpts != nil && batch.validateOpts.BypassCompanyIdentificationMatch) {
			return batch.Error("CompanyIdentification",
				NewErrBatchHeaderControlEquality(batch.Header.CompanyIdentification, batch.Control.CompanyIdentification))
		}

		// Control ODFIIdentification must be the same as batch header
		if batch.Header.ODFIIdentification != batch.Control.ODFIIdentification {
			return batch.Error("ODFIIdentification",
				NewErrBatchHeaderControlEquality(batch.Header.ODFIIdentification, batch.Control.ODFIIdentification))
		}
		// batch number header and control must match
		if batch.Header.BatchNumber != batch.Control.BatchNumber {
			return batch.Error("BatchNumber",
				NewErrBatchHeaderControlEquality(batch.Header.BatchNumber, batch.Control.BatchNumber))
		}
	} 

[adamdecaf]

Does setting UnequalServiceClassCode: true fix your issue?

https://pkg.go.dev/github.com/moov-io/ach?utm_source=godoc#ValidateOpts.UnequalServiceClassCode