Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reader: lower hard limit of lines to consume and make it configurable #1120

Closed
adamdecaf opened this issue Oct 27, 2022 · 0 comments · Fixed by #1138
Closed

reader: lower hard limit of lines to consume and make it configurable #1120

adamdecaf opened this issue Oct 27, 2022 · 0 comments · Fixed by #1138
Labels
enhancement good first issue
Milestone
v1.24.0

Comments

@adamdecaf
Copy link
Member

From #1119 it came up that we allow a pretty large amount of memory to be consumed, which isn't ideal. We should lower that default to be safer and to allow that value to be configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
v1.24.0
Development

Successfully merging a pull request may close this issue.

feat: add .SetMaxLines(int) to Reader adamdecaf/ach
1 participant
@adamdecaf