make achcli -skip-validation flag not depend on -validate <filepath> being present #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esent right now `-skip-validation` is only considered if the -validate flag is present; the name of the flag implies it being a boolean flag and it is unintuitive that it needs another flag to be present referencing a config file that will be ignored
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
- Coverage 84.66% 84.65% -0.02%
==========================================
Files 84 84
Lines 8406 8407 +1
==========================================
Hits 7117 7117
- Misses 902 903 +1
Partials 387 387 |
adamdecaf
approved these changes
Apr 29, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
-skip-validationis only considered if the-validateflag ispresent. The name of the flag implies it being a boolean flag and it is
unintuitive that it needs another flag to be present referencing a
config file that will be ignored. I am unsure if this was intended behaviour but it felt unintuitive and it lead me to have to debug where I call the
achclitool until I realised this was the behaviour.fixes #1414