Keep settlement date when parsing files. #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 91.32% 92.22% +0.89%
==========================================
Files 66 66
Lines 5247 6060 +813
==========================================
+ Hits 4792 5589 +797
- Misses 282 295 +13
- Partials 173 176 +3 |
adamdecaf
reviewed
Jul 19, 2021
eweise
force-pushed
the
capture-settlement-date
branch
from
1998e0f
to
acdfe2b
Compare
adamdecaf
previously approved these changes
Jul 19, 2021
vxio
previously approved these changes
Jul 19, 2021
Co-authored-by: Vincent Xiao <vincentx72@gmail.com>
Co-authored-by: Vincent Xiao <vincentx72@gmail.com>
adamdecaf
approved these changes
Jul 20, 2021
vxio
approved these changes
Jul 20, 2021
|
Appreciate the PR @eweise , I'm going to merge this in! |
|
Awesome. Thank you both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.