Implementing CustomReturnCode validation #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
reviewed
Jul 22, 2021
|
|
||
| // CustomReturnCodes can be set to skip validation for the Return Code field in an Addenda99 | ||
| // This allows for non-standard/deprecated return codes (e.g. R97) | ||
| CustomReturnCodes bool `json:"customReturnCodes"` |
There was a problem hiding this comment.
@vxio What are your thoughts on a CheckReturnCode func(code string) error function that allows validating codes like "R97" as the issue mentions.
There was a problem hiding this comment.
I went with the bool so that I can call from an API endpoint more easily with the base docker image
There was a problem hiding this comment.
Yea that's a good idea. We can add a validation func in a separate PR.
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 92.22% 92.23% +0.01%
==========================================
Files 66 66
Lines 6058 6068 +10
==========================================
+ Hits 5587 5597 +10
+ Misses 295 294 -1
- Partials 176 177 +1 |
adamdecaf
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing new custom validator
customReturnCodethat allows returns with non-standard return codes to be parsed successfully.Fixes #964