Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tornado dependency breaks with v5.0 #28

Open
da4089 opened this issue Mar 7, 2018 · 0 comments
Open

tornado dependency breaks with v5.0 #28

da4089 opened this issue Mar 7, 2018 · 0 comments

Comments

@da4089
Copy link

da4089 commented Mar 7, 2018

Tornado has recently released their v5.0, which breaks pypi-server's handlers/pypi/proxy/client.py on line 33 where it constructs AsyncHTTPClient passing in an io_loop parameter. It seems v5.0 doesn't support this parameter any longer.

Changing setup.py to further restrict Tornado to tornado>=4.3,<5.0 should fix it until it can be figured out what Tornado is doing with their event loop.

Tested with v5.0 and v4.5.3.

[C 180307 16:08:10 server:204] Exception on main loop:
[E 180307 16:08:10 server:205] initialize() got an unexpected keyword argument 'io_loop'
    Traceback (most recent call last):
      File "/Users/d/work/hmc/hmops/docker/images/pypi_server/venv36/lib/python3.6/site-packages/pypi_server/server.py", line 185, in run
        handlers.base.BaseHandler.THREAD_POOL
      File "/Users/d/work/hmc/hmops/docker/images/pypi_server/venv36/lib/python3.6/site-packages/pypi_server/handlers/pypi/proxy/client.py", line 33, in configure
        cls.CLIENT = AsyncHTTPClient(io_loop=IOLoop.current())
      File "/Users/d/work/hmc/hmops/docker/images/pypi_server/venv36/lib/python3.6/site-packages/tornado/httpclient.py", line 171, in __new__
        instance = super(AsyncHTTPClient, cls).__new__(cls, **kwargs)
      File "/Users/d/work/hmc/hmops/docker/images/pypi_server/venv36/lib/python3.6/site-packages/tornado/util.py", line 312, in __new__
        instance.initialize(*args, **init_kwargs)
    TypeError: initialize() got an unexpected keyword argument 'io_loop'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant