Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview-only Background Color #1018

Open
mxsdev opened this issue Apr 1, 2024 · 1 comment · May be fixed by #1027
Open

Preview-only Background Color #1018

mxsdev opened this issue Apr 1, 2024 · 1 comment · May be fixed by #1027
Assignees
Labels
a-core Relates to the core package b-enhancement New feature or request c-accepted The issue is ready to be worked on

Comments

@mxsdev
Copy link

mxsdev commented Apr 1, 2024

Description
Would be nice to have a separate preview/viewport background color setting which doesn't affect the render. This is particularly useful when you want to export with a transparent background (to add perhaps a more complex background in post), but still want to get an idea of how it will look roughly while editing.

Proposed solution
Add an extra Video Setting under preview for "background". When empty, this will default to the General background, and when non-empty, this will become the background color for the viewport. This will not affect the render result at all - that will still use the background under "General".

Considered alternatives
Alternative is to change the background every time you need to render and then change it back for preview purposes. For scenarios where there are many scenes to render, this becomes tiresome quickly.

Additional context
Happy to make a PR for this, it seems fairly straight-forward :)

@mxsdev mxsdev added the b-enhancement New feature or request label Apr 1, 2024
@aarthificial
Copy link
Contributor

I think it's a great idea. But we should stay consistent with other settings and make the background setting separate for the preview and for the rendering without any inheritance/default behavior (for now).

Having a way to override the settings when previewing is an interesting idea but it should be implemented in a separate PR and affect other similar settings like FPS or Scale.

@aarthificial aarthificial added c-accepted The issue is ready to be worked on a-core Relates to the core package labels Apr 6, 2024
@aarthificial aarthificial assigned mxsdev and unassigned aarthificial Apr 6, 2024
@mxsdev mxsdev linked a pull request Apr 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-core Relates to the core package b-enhancement New feature or request c-accepted The issue is ready to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants