Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dygraphs options status #2

Open
motiz88 opened this issue Nov 18, 2015 · 4 comments
Open

Dygraphs options status #2

motiz88 opened this issue Nov 18, 2015 · 4 comments

Comments

@motiz88
Copy link
Owner

motiz88 commented Nov 18, 2015

This is a master issue tracking the implementation of appropriate React-ish wrappers for all dygraphs options.

The option names link to dygraph's documentation.
Links to sub-issues, PRs, commits, etc. will be added after them as needed.
Please discuss specific options in dedicated issues and not in this thread.

@dmr
Copy link

dmr commented Feb 6, 2016

How is the status on this feature? Your commit looks like many of the options are mapped already. Are they?

@motiz88
Copy link
Owner Author

motiz88 commented Feb 7, 2016

Hi @dmr! They are practically all mapped, but untested - Meaning that I don't have first-hand knowledge that they work OK (or at all). I prefer to be careful here and not mark untested features as done.

Sadly, I have no active plans to add systematic tests at the moment, which would be the best way forward. But I'll definitely welcome such a PR.

@pgruenbacher
Copy link

dataWindow should be dateWindow?

@Jet-Set-Willy
Copy link

dataWindow should indeed be dateWindow

http://dygraphs.com/options.html#dateWindow

saboya added a commit to Qogni/react-dygraphs that referenced this issue Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants