propTypes validation on data causes performance issue

[burgalon]

Because of the propTypes defined on data, when dealing with multiple graphs of +180 ticks, you start to get a serious lag and browser hanging because of prop types validation

[motiz88]

Thanks for the report. I'm not willing to give up propTypes validation outright but if you have a suggested fix, I'd love to see a PR. In any case this issue impacts dev workflows only, since propTypes checks are generally not used in production.

[motiz88]

A good compromise here might be to use a custom validation function in place of (the outermost) React.propTypes.arrayOf, so that we'll always inspect an O(1) sample of the data array, rather than all elements. That way we'll still guard against major errors and ensure that the user at least appears to know what they're doing.

[pgruenbacher]

I faced a similar performance hit when in developing environment.

[burgalon]

@pgruenbacher
Infinidat@ef501e1
published as infinidat-react-dygraphs