Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React should be a peerDependency #5

Open
burgalon opened this issue Feb 3, 2016 · 3 comments
Open

React should be a peerDependency #5

burgalon opened this issue Feb 3, 2016 · 3 comments

Comments

@burgalon
Copy link

burgalon commented Feb 3, 2016

No description provided.

@motiz88
Copy link
Owner

motiz88 commented Feb 3, 2016

Please write an issue description with at least a brief explanation or pointer as to why you think so. Thanks.

@burgalon
Copy link
Author

burgalon commented Feb 3, 2016

take a look here facebook/react#2402

@motiz88
Copy link
Owner

motiz88 commented Feb 3, 2016

I don't really see how that reasoning applies here.

The only way react-dygraphs will cause a local react to be installed and loaded is via devDependencies, which in normal usage (running the demo code etc) won't collide with any other React instance. And if it does somehow collide in your workflow, I don't think peerDependencies can help.

Having said that, react-dygraphs does implicitly depend on React 0.14's API, so I'll accept a PR that makes that explicit in peerDependencies.

dmr referenced this issue in Infinidat/react-dygraphs Feb 6, 2016
@burgalon
new package for NPM
345d58b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burgalon @motiz88