Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] replace moul.io refs with github.com #167

Open
amalone-scwx opened this issue Nov 3, 2020 · 0 comments
Open

[security] replace moul.io refs with github.com #167

amalone-scwx opened this issue Nov 3, 2020 · 0 comments

Comments

@amalone-scwx
Copy link
Contributor

The go.mod and source code references moul.io/protoc-gen-gotemplate rather than github.com/moul/protoc-gen-gotemplate. Using a personal DNS is a potential security problem, as the code could be changed from that published on GitHub. To protect against this, projects that use this repo would have to qualify all refs with hashes rather than just the version.

I am guessing that you do this to make it easier to test locally and override the domain name? I'm not a fan of how Go uses URL refs, rather than published package refs to crates.io or the like.

In any case, is there a chance you can revert the source back to using GitHub.com urls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant