Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 2 admin signoffs for changes to permissions #2194

Open
bhearsum opened this issue Sep 16, 2021 · 0 comments · May be fixed by #3088
Open

Require 2 admin signoffs for changes to permissions #2194

bhearsum opened this issue Sep 16, 2021 · 0 comments · May be fixed by #3088
Assignees
Labels
admin admin app & api (aus4-admin.mozilla.org)

Comments

@bhearsum
Copy link
Contributor

Currently, we calculate the signoffs required for changes to permissions by taking the full set of all product signoffs (

def getPotentialRequiredSignoffs(self, affected_rows, transaction=None):
). This often means that we need 2, 3, or sometimes even 5 signoffs to make a simple change to permissions.

We should adjust this to require just two signoffs in total. Ideally, it would require them from a full fledged admin (ie: has admin permission without any conditions attached). If this ends up being too difficult (it my - because it moves us from looking at "roles" when checking signoffs to looking at "permissions" -- it also may complicate the UI) -- we could consider hardcoding 2 "releng" signoffs instead. We'd have to evaluate potential security issues before going that route - most importantly, we need to make sure that nobody currently has that role that shouldn't, and cannot be granted it by anybody other than a full fledged admin.

@bhearsum bhearsum added the admin admin app & api (aus4-admin.mozilla.org) label Sep 16, 2021
@gabrielBusta gabrielBusta self-assigned this May 11, 2022
@michellemounde michellemounde linked a pull request Jan 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants