Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

intermittent selenium bug: UnhandledPromiseRejectionWarning #4109

Closed
jaredhirsch opened this issue Feb 13, 2018 · 1 comment
Closed

intermittent selenium bug: UnhandledPromiseRejectionWarning #4109

jaredhirsch opened this issue Feb 13, 2018 · 1 comment
Assignees
@chenba
Labels
testing Tests or test infrastructure
Milestone
Sprint 7 (60-2) 🏏

Comments

@jaredhirsch
Copy link
Member

Related to #4108, I thought mocha should gracefully handle uncaught Promise failures, but I guess not. Maybe we need to add a generic .catch(err => fail(err)) or something throughout?
@ianb ianb added the testing Tests or test infrastructure label Feb 14, 2018
@ianb ianb added this to the Sprint 7 (60-2) 🏏 milestone Feb 14, 2018
@chenba chenba self-assigned this Feb 16, 2018
@chenba
Copy link
Collaborator

chenba commented Feb 16, 2018

This is not something handled by mocha yet: mochajs/mocha#2640

chenba added a commit to chenba/screenshots that referenced this issue Feb 16, 2018
@chenba
Use done cb in Selenium tests. (mozilla-services#4109)
95577ef
@chenba chenba mentioned this issue Feb 16, 2018
Merged
jaredhirsch pushed a commit that referenced this issue Feb 16, 2018
@chenba @jaredhirsch
Use done cb in Selenium tests. (#4109) (#4123)
ec53f04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
testing Tests or test infrastructure
Projects
None yet
Milestone
Sprint 7 (60-2) 🏏
Development

No branches or pull requests
3 participants
@ianb @jaredhirsch @chenba