Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMO Extension validator uses the outdated rules #3836

Closed
muffinresearch opened this issue Jul 30, 2021 · 4 comments
Closed

AMO Extension validator uses the outdated rules #3836

muffinresearch opened this issue Jul 30, 2021 · 4 comments

Comments

@muffinresearch
Copy link
Contributor

Re-filed from https://bugzilla.mozilla.org/show_bug.cgi?id=1722817

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4495.0 Safari/537.36

Steps to reproduce:

Try to submit the attached extension to addons.mozilla.org

Actual results:

The extension is successfully accepted.

Expected results:

The extension is rejected:
JavaScript syntax error (Parsing as module error: Unexpected token = at line: 3 and column: 17) (Parsing as script error: Unexpected token = at line: 3 and column: 17)
JavaScript syntax error (Parsing as module error: Unexpected token = at line: 4 and column: 17) (Parsing as script error: 'import' and 'export' may appear only with 'sourceType: module' at line: 1 and column: 1)

The validator can't work with ES6 imports and with class static properties.

While the extension works fine even in Firefox ESR (78) (the actual Firefox version is 90).

@muffinresearch
Copy link
Contributor Author

See the original bug for the extension and further information from QA.

@wagnerand
Copy link
Member

wagnerand commented Jul 30, 2021

Parts of this sound similar to #3062.

@willdurand
Copy link
Member

I am not sure what "outdated rules" means. The linter is very up-to-date on AMO.

Public/class field declarations are not yet fully supported by ESLint, see: eslint/eslint#14343. It's almost there, though.

There is nothing we can do so unless I have overlooked something, we can close this bug.

@willdurand
Copy link
Member

As discussed during our triage meeting, it is a duplicate issue and there is nothing we can do right now. We're following the progress of ESLint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants