From a719bd0651859ad5080da3f9db58e37a0fbc2aac Mon Sep 17 00:00:00 2001
From: William Durand <will+git@drnd.me>
Date: Tue, 14 Sep 2021 11:26:01 +0200
Subject: [PATCH] Prevent error when strict_min_version is not a string value

---
 src/utils.js             | 3 ++-
 tests/unit/test.utils.js | 8 ++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/utils.js b/src/utils.js
index 219c35bd24..2de6a99fad 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -398,7 +398,8 @@ export function firefoxStrictMinVersion(manifestJson) {
   if (
     manifestJson.applications &&
     manifestJson.applications.gecko &&
-    manifestJson.applications.gecko.strict_min_version
+    manifestJson.applications.gecko.strict_min_version &&
+    typeof manifestJson.applications.gecko.strict_min_version === 'string'
   ) {
     return parseInt(
       manifestJson.applications.gecko.strict_min_version.split('.')[0],
diff --git a/tests/unit/test.utils.js b/tests/unit/test.utils.js
index f38de519c4..3d3d73e91c 100644
--- a/tests/unit/test.utils.js
+++ b/tests/unit/test.utils.js
@@ -512,6 +512,14 @@ describe('firefoxStrictMinVersion', () => {
       })
     ).toEqual(60);
   });
+
+  it('should return null when value is not a string', () => {
+    expect(
+      firefoxStrictMinVersion({
+        applications: { gecko: { strict_min_version: 12.3 } },
+      })
+    ).toEqual(null);
+  });
 });
 
 describe('basicCompatVersionComparison', () => {