Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix less v4 breakage #16250

Closed
eviljeff opened this issue Jan 4, 2021 · 1 comment · Fixed by #16251
Closed

Fix less v4 breakage #16250

eviljeff opened this issue Jan 4, 2021 · 1 comment · Fixed by #16251
Assignees
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented Jan 4, 2021

identified in #16205 (comment) by @diox

less v4 makes a number of changes, one of which is less/less.js@67ce103 "Require parens after mixin call" - this is causing the less compilation step to fail. We don't fail during the assets build for this so it doesn't trigger a fail in CI; it's unclear what the actual result of this is on AMO either because there's a lot of cruft from the legacy frontend so it may be an unused file anyway.

It will be safer to fix the syntax failure in the less file for now.

@ioanarusiczki
Copy link

@eviljeff Please add some str for qa.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants