Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-redux to v7 #13822

Closed
bobsilverberg opened this issue Sep 18, 2020 · 3 comments
Closed

Update react-redux to v7 #13822

bobsilverberg opened this issue Sep 18, 2020 · 3 comments
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@bobsilverberg
Copy link
Contributor

In addition to updating react-router (see #2085), we should also try to update react-redux to the latest version, which is 7.2.1. This issue will replace mozilla/addons-frontend#9627.

I noticed that we use connected-react-router v5.0.1, but it has actually released v6.8.0, which requires react-redux version 6 or 7, but we're currently still on v5. So it seems like it makes sense to attempt the react-redux upgrade first, and then react-router, which could either be combined with, or followed by an upgrade to connected-react-router v6.
@bobsilverberg bobsilverberg self-assigned this Sep 18, 2020
@bobsilverberg bobsilverberg modified the milestones: 2020.09.24, 2020.10.01 Sep 18, 2020
@willdurand
Copy link
Member

There was an issue about it already: #2073

@bobsilverberg
Copy link
Contributor Author

Ok, we should probably close this one then. Do you agree?

@willdurand
Copy link
Member

yes

@willdurand willdurand removed this from the 2020.10.01 milestone Sep 25, 2020
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bobsilverberg @willdurand @KevinMind